publish to PyPI as rsconnect and rsconnect-python#667
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
|
It might be worth reverting from |
.github/workflows/main.yml
Outdated
| - uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: 3.8.x | ||
| - name: Install uv # see scripts/temporary-rename | ||
| uses: astral-sh/setup-uv@v5 |
There was a problem hiding this comment.
Set up Python using uv: https://github.com/posit-dev/posit-sdk-py/blob/main/.github/workflows/ci.yaml#L32-L33
Should be faster.
There was a problem hiding this comment.
Looks like the python version is builtin now as well:
uses: astral-sh/setup-uv@v6
with:
python-version: ${{ matrix.python-version }}There was a problem hiding this comment.
I think that changes a few assumptions about how package installation works in the rest of the steps, which I'd prefer to leave in place for now.
I think we could simplify much of the build infrastructure here out of docker and into uv and that's probably worth doing on its own.
|
Ya, it's just unconventional for the name field in pyproject.toml to be dynamic. I guess publishing the same project under two different names is also unconventional. Why not stop using |
I think it will make sense to keep both versions on PyPI up to date until we have the opportunity to update the places where the CLI is used. |
edavidaja
force-pushed
the
pip-install-rsconnect
branch
from
59a9cea to
2e7ff0d
Compare
edavidaja
force-pushed
the
pip-install-rsconnect
branch
from
2e7ff0d to
0268029
Compare
|
|
Merging here appears to be blocked because of the |
- update makefile to support building wheels with a different package name
- add a script to rewrite the package name in CI
- `uv run` is used for this so that the necessary `toml` dependency
is installed without drama
- matrix the distributions step
- change how dev version numbers are set in build
edavidaja
force-pushed
the
pip-install-rsconnect
branch
from
5d735a6 to
15b5a09
Compare
|
matrixing the distributions job caused the branch protection rules to go out of sync (see this discussion); I've disabled just the branch protection rule requiring a passing of the distributions check, which I will re-add if I can get it to pass here or after it merges to main. |
|
re-enabled branch protections for the distributions jobs before merging |
2 participants
uv runis used for this so that the necessarytomldependencyis installed without drama