Feat/fire and forget remote #2792
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skyline-23
force-pushed
the
feat/fire-and-forget-remote
branch
from
13b792e to
873df66
Compare
Author
|
@postlund how about rebase this branch instead of merge main branch into feature branch? |
Owner
Yes, that would be great! I guess "Update" became a merge. |
Skyline-23
force-pushed
the
feat/fire-and-forget-remote
branch
from
cb8fd74 to
a4b4acb
Compare
…rors Add an opt-in fire-and-forget path for MRP remote commands while keeping defaults unchanged; allow overriding command timeouts. Treat closed transports during send as ConnectionLostError with an explicit reconnect hint and convert response timeouts to OperationTimeoutError. Cover the new behaviors in mrp protocol/interface tests. # Conflicts: # pyatv/protocols/mrp/protocol.py
Add send_command entry point to RemoteControl interface and relay it via FacadeRemoteControl so consumers can use fire-and-forget/timeout overrides from supporting protocols.
Skyline-23
force-pushed
the
feat/fire-and-forget-remote
branch
from
a4b4acb to
ee56bfa
Compare
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several reliability and usability improvements to the MRP protocol implementation, focusing on robust connection handling, improved command sending flexibility, and enhanced compatibility with sandboxed network environments. It also adds new tests to ensure correct behavior in these areas.
MRP Protocol Reliability and Command Handling:
sendandsend_rawmethods ofMrpConnection, raisingConnectionLostErrorif the connection is closed or lost during send operations. [1] [2]MrpProtocolto centralize connection state checks with_ensure_send_possible, ensuring proper exceptions are raised for invalid or closed states. Enhancedsendandsend_and_receiveto handle fire-and-forget (no response) operations and propagate connection errors. [1] [2] [3]_send_commandand publicsend_commandinMrpRemoteControlto support fire-and-forget commands and custom timeouts, improving API flexibility. [1] [2] [3]Network Compatibility Improvements:
Testing Enhancements: