Merged
Conversation
… improve errors for opening a DB.
stevensJourney
commented
Jan 27, 2025
rkistner
approved these changes
Jan 27, 2025
Contributor
rkistner
left a comment
There was a problem hiding this comment.
Looks good overall, but did not check all the concurrency logic in detail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This adds extra checks and mutex locks to the
.closemethod. This should prevent some cases where closing a database might crash the application.This PR includes 2 fixes which should help with crashes.
The first fix involves clearing callbacks for the SQLite commit and table change hooks on close. These hooks are handled asynchronously and are called via the React native invoker. A race condition could occur where an async callback is executed after the connection has closed and memory has been freed. The callback handlers now use safe shared pointer which is used to check if the connection is closed - if closed the callback execution is ended.
The second fix involves improving the
waitForFinishedlogic has which occurs on close. This should prevent SQLite operations on a closed database. The JSwriteandreadlocks will now also reject any pending requests if the database has been closed.Units tests have been added to ensure the
closemethod works correctly.Tests pass on Android and iOS locally.
TODOs