Attempt to make a layout engine that takes the topology and LayoutSpe…#107
Merged
pragmatrix merged 11 commits intomasterfrom Feb 24, 2026
Merged
Attempt to make a layout engine that takes the topology and LayoutSpe…#107pragmatrix merged 11 commits intomasterfrom
pragmatrix merged 11 commits intomasterfrom
Conversation
…cs from external sources and layouts incrementally
83286e5 to
49d34d5
Compare
…okups get simpler and general path integrity is given
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces an incremental layout engine that can recompute geometry based on an external topology + algorithm, and wires it into the desktop system to replace the prior “build full layout tree then place” approach.
Changes:
- Added
IncrementalLayouter(withLayoutTopology/LayoutAlgorithm) to support incremental measure/place and emit only changed rects. - Switched
DesktopSystemlayout application to use incremental recomputation and removed the separaterectscache. - Refactored
OrderedHierarchyto store hierarchy relationships in a single node-state map (parent + ordered children) and addedexists().
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| layout/src/lib.rs | Exposes the new incremental layouter module publicly. |
| layout/src/incremental_layouter.rs | Implements incremental recompute, caching, eviction, and unit tests. |
| desktop/src/desktop_system.rs | Replaces old layout building/placing with incremental recompute + change application; integrates hit testing + rect lookup with the layouter. |
| desktop/src/aggregates/ordered_hierarchy.rs | Consolidates hierarchy state into a single nodes map and adds exists() for topology queries. |
| .github/copilot-instructions.md | Documents new guidance around single source of truth, hierarchy representation, and invariant handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cs from external sources and layouts incrementally