Skip to content

Conversation

@Ishaan-2312
Copy link

@Ishaan-2312 Ishaan-2312 commented Jan 27, 2026

Description

docs: clarify ANALYZE connector support

This change updates documentation to reflect that the ANALYZE statement
is supported by both Hive and Iceberg connectors.

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... 
* ... 

Hive Connector Changes
* ... 
* ... 

If release note is NOT required, use:

== NO RELEASE NOTE ==

Summary by Sourcery

Documentation:

  • Clarify and expand ANALYZE command documentation to include Iceberg connector support.

@Ishaan-2312 Ishaan-2312 requested review from a team, elharo and steveburnett as code owners January 27, 2026 10:48
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 27, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: Ishaan-2312 / name: Ishaan Bansal (8ca6034)

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 27, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the SQL ANALYZE command documentation to describe support and behavior for the Iceberg connector in analyze.rst.

File-Level Changes

Change Details Files
Extend ANALYZE documentation to cover Iceberg connector support and behavior.
  • Add Iceberg connector to the list of connectors supporting ANALYZE, including any prerequisites or limitations.
  • Describe how ANALYZE works for Iceberg tables, including statistics collection semantics and scope.
  • Clarify or align wording so Iceberg behavior is consistent with existing connector docs (e.g., Hive) where applicable.
presto-docs/src/main/sphinx/sql/analyze.rst

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at the comments and let me know if you have questions.

@@ -22,6 +22,7 @@ connector-specific properties. To list all available properties, run the followi

Currently, this statement is only supported by the
:ref:`Hive connector <hive_analyze>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:ref:`Hive connector <hive_analyze>`.
:ref:`Hive connector <hive_analyze>` and the :ref:`Iceberg connector <iceberg_analyze>`.

Syntax of the Iceberg link fixed - you had added a space after the ref: in the Iceberg link so the current file looked like this in a local doc build.
Screenshot 2026-01-27 at 10 33 48 AM

Local doc builds are helpful to find formatting mistakes. For more information on running local doc builds, see Building the Documentation in the Presto docs README.


Currently, this statement is only supported by the
:ref:`Hive connector <hive_analyze>`.
:ref: `Iceberg connector <iceberg_analyze>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After fixing the link as mentioned in the other comment, the link does not appear to have a valid destination.
Screenshot 2026-01-27 at 10 44 27 AM

Please edit the link so that it links to a destination.

@github-project-automation github-project-automation bot moved this from 🆕 Unprioritized to 🏗 In progress in Presto Documentation Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

2 participants