Fix the GoldenrodUndergroundSwitchRoomEntrances door-switch macros#1245
Open
Rangi42 wants to merge 1 commit intopret:masterfrom
Open
Fix the GoldenrodUndergroundSwitchRoomEntrances door-switch macros#1245Rangi42 wants to merge 1 commit intopret:masterfrom
GoldenrodUndergroundSwitchRoomEntrances door-switch macros#1245Rangi42 wants to merge 1 commit intopret:masterfrom
Conversation
5e05cb5 to
984b842
Compare
Rangi42
added a commit
to Rangi42/polishedcrystal
that referenced
this pull request
Feb 23, 2026
Member
Author
|
This is an example of what it looks like to shift/change all the door coordinates and IDs: Rangi42/polishedcrystal@46f7d69#diff-c0a6db620bab535fdf6d747b731136e0a9160cf1a95711d4801da7d7e1e34b3d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bulbapedia documents how the Goldenrod Underground switch room works:
The
ugdoor_defandchangeugdoormacros in this PR correspond to that diagram.The previous
ugdooranddoorstatemacros had a number of problems:EVENT_SWITCH_flags, when actually there are 3 switches and 11 door statesI did not keep the original macro names, partly because I think the new ones better match typical script commands (
changedoorstatevschangeblock,ugdoor_defvswarp_def) and partly to avoid any confusion about whether someone's code has old vs new behavior.Mostly what I'm looking for in a review is feedback on whether I'm going too far with macros and
forloops.