Add maximum value limit checks to constant definitions#561
Draft
Rangi42 wants to merge 2 commits intopret:masterfrom
Draft
Add maximum value limit checks to constant definitions#561Rangi42 wants to merge 2 commits intopret:masterfrom
Rangi42 wants to merge 2 commits intopret:masterfrom
Conversation
Engezerstorung
added a commit
to Engezerstorung/pokered
that referenced
this pull request
Jan 9, 2026
Took inspiration of macros bit_const_def from rangi42 pr pret#561 with a different approach. They dont define a limit, but the "format" expected for the constant values.
Engezerstorung
added a commit
to Engezerstorung/pokered
that referenced
this pull request
Jan 9, 2026
| call GetPredefRegisters | ||
| push hl | ||
| ; hl = Tilesets + [wCurMapTileset] * 12 | ||
| ; (this would overflow for a tileset ID greater than 31) |
Contributor
There was a problem hiding this comment.
I think the placement of the comment could lead to confusion for people starting with asm.
If i was starting myself i would assume that im being told that hl would be the value of the comment at the point it is inserted instead of later.
The original comment making it clear that it is now x12 at the moment of the instruction.
Engezerstorung
added a commit
to Engezerstorung/pokered
that referenced
this pull request
Jan 9, 2026
Engezerstorung
added a commit
to Engezerstorung/pokered
that referenced
this pull request
Jan 9, 2026
Engezerstorung
added a commit
to Engezerstorung/pokered
that referenced
this pull request
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A potential alternative approach to #558