fix: move NODE_ENV checks first to fix treeshaking artifacts
#425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angeloashmore
approved these changes
Dec 31, 2025
Member
angeloashmore
left a comment
angeloashmore
left a comment
There was a problem hiding this comment.
Wow, nice find! I guess it makes sense since the previous cases need to be evaluated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #424
Description
It appears that treeshaking can leave artifacts in clauses when static checks come last. This PR fixes that by moving the
NODE_ENVchecks first, which should hopefully clean up the treeshaking artifacts.See: https://rollupjs.org/repl/?version=4.54.0&shareable=eyJleGFtcGxlIjpudWxsLCJtb2R1bGVzIjpbeyJjb2RlIjoiaWYgKC8oPzwhXFwuY2RuKVxcLnByaXNtaWNcXC5pbyQvaS50ZXN0KG5ldyBVUkwoXCJoYXMgYXJ0aWZhY3RzXCIpLmhvc3RuYW1lKSAmJiBmYWxzZSkge31cblxuaWYgKGZhbHNlICYmIC8oPzwhXFwuY2RuKVxcLnByaXNtaWNcXC5pbyQvaS50ZXN0KG5ldyBVUkwoXCJhcnRpZmFjdC1mcmVlXCIpLmhvc3RuYW1lKSkge30iLCJpc0VudHJ5Ijp0cnVlLCJuYW1lIjoibWFpbi5qcyJ9XSwib3B0aW9ucyI6eyJvdXRwdXQiOnsiZm9ybWF0IjoiZXMifSwidHJlZXNoYWtlIjp0cnVlfX0=
Checklist
Preview
npm install @prismicio/client@pr-425How to QA 1
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩