This repository was archived by the owner on Dec 27, 2023. It is now read-only.
Open
Conversation
Member
|
Thanks for the pull! Can you list the types of lint changes you made? It will help speed up the review process.
|
changed 4 space indents to 2 space indents
codethejason
force-pushed
the
develop
branch
from
90a3fa9 to
125bacf
Compare
Author
|
Added the changes to the description. |
Member
|
Noting: Separately @codethejason told me he used http://jsbeautifier.org/ and https://github.com/beautify-web/js-beautify for this. |
|
|
||
| createSeamlessMenuItem('New Message', 'Message'); | ||
| createSeamlessMenuItem('New PlainPost', 'PlainPost'); | ||
| createSeamlessMenuItem('New PlainPost', 'PlainPost'); No newline at end of file |
Member
There was a problem hiding this comment.
Nit: you removed the newline character from the file
Member
|
I reviewed half the changes, but since I am asking you to not remove the end of file line breaks, I am going to stop reviewing until it is likely the last time I look it over. I have to check every change you introduce at the time I merge it -- and you have many changes here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linted the application javascript files using Adobe Bracket's built in JSLint.
-Indentations and other formatting
-Added 'use strict'
-similar var declarations on same indentation level are grouped together