Skip to content

Comments

fix(apm): rename phone "value" to "number" to conform with the BE API contracts#225

Merged
tomasz-pazdziurek-cko merged 3 commits intomasterfrom
fix/apm-phone-number-field-name
Dec 2, 2025
Merged

fix(apm): rename phone "value" to "number" to conform with the BE API contracts#225
tomasz-pazdziurek-cko merged 3 commits intomasterfrom
fix/apm-phone-number-field-name

Conversation

@tomasz-pazdziurek-cko
Copy link
Contributor

@tomasz-pazdziurek-cko tomasz-pazdziurek-cko commented Nov 28, 2025

Description

We're sending phone number as "value" field instead of "number" and BE ignores it. As a result, we end up sending empty phone number to the PSP.

Solution

Rename "value" field to "number" to conform with the BE API contracts.

Demo

Screen.Recording.2025-11-28.at.13.03.50.mov

Checklist

  • I bumped the version of the project using yarn bump-version
  • I have checked the code for any potential issues
  • I tested my changes in the browser

Notes

Jira Issue

@tomasz-pazdziurek-cko tomasz-pazdziurek-cko marked this pull request as ready for review November 28, 2025 14:47
@tomasz-pazdziurek-cko tomasz-pazdziurek-cko marked this pull request as draft November 28, 2025 14:48
@tomasz-pazdziurek-cko tomasz-pazdziurek-cko marked this pull request as ready for review December 2, 2025 09:45
@tomasz-pazdziurek-cko tomasz-pazdziurek-cko merged commit da68676 into master Dec 2, 2025
5 checks passed
@tomasz-pazdziurek-cko tomasz-pazdziurek-cko deleted the fix/apm-phone-number-field-name branch December 2, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants