Skip to content

Fix for incorrect equihash and cryptonight block headers response #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jimmypound wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for incorrect equihash and cryptonight block headers response #133

jimmypound wants to merge 2 commits into from

Conversation

@jimmypound
Copy link

@jimmypound jimmypound commented Aug 2, 2024

This PR:

  • reverts commit 2669119 because it breaks the build
  • fixes bug where Bitmark node returns incorrect block headers for equihash and cryptonight blocks when "getheaders" are requested. This is not the issue for bitmark v.0.9.7 because nodes do not use "getheaders" for chain sync. It creates a problem for the newer version where chain sync is conducted in two phases. In the first phase, headers are fetched, and if headers are correct then whole blocks are requested.

@jimmypound
Revert "Prepend std::placeholders namespace to placeholder arguments …
c666391 
…of boost::bind()"

This reverts commit 2669119.
@jimmypound
Fix for the bug when the node returns incorrect block headers for equ…
e42476f 
…ihash and cryptonight blocks when "getheaders" are requested.
This was referenced Aug 2, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jimmypound