Skip to content

Translate quote-quote as an "empty" limit #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AryaHassanli wants to merge 1 commit into
base: main
Choose a base branch
from
+971 −961
Open

Translate quote-quote as an "empty" limit #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion matter/constraint/grammar/limit.peg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ UnspecifiedLimit <- ("-" / "–" / "N/A"i) EOF {
return &UnspecifiedLimit{}, nil
}

EmptyLimit <- ("empty" / "[]") {
EmptyLimit <- ("empty" / "[]" / "\"\"") {
Copy link

@gemini-code-assist gemini-code-assist bot Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this change correctly adds "" as a syntax for EmptyLimit, I've noticed that there are no existing tests for EmptyLimit in matter/constraint/constraint_test.go. It's important to add tests to cover this functionality, especially when modifying the grammar.

Please add test cases for all three variants of EmptyLimit (empty, [], and the new "") to constraintTests in matter/constraint/constraint_test.go. This will ensure the parser behaves as expected and prevent future regressions.

Here are some suggested test cases:

	{
		constraint: "empty",
		dataType:   &types.DataType{BaseType: types.BaseDataTypeList},
		min:        types.DataTypeExtreme{Type: types.DataTypeExtremeTypeEmptyList, Format: types.NumberFormatHex},
		max:        types.DataTypeExtreme{Type: types.DataTypeExtremeTypeEmptyList, Format: types.NumberFormatHex},
	},
	{
		constraint: "[]",
		asciiDoc:   "empty",
		dataType:   &types.DataType{BaseType: types.BaseDataTypeList},
		min:        types.DataTypeExtreme{Type: types.DataTypeExtremeTypeEmptyList, Format: types.NumberFormatHex},
		max:        types.DataTypeExtreme{Type: types.DataTypeExtremeTypeEmptyList, Format: types.NumberFormatHex},
	},
	{
		constraint: `""`,
		asciiDoc:   "empty",
		dataType:   &types.DataType{BaseType: types.BaseDataTypeList},
		min:        types.DataTypeExtreme{Type: types.DataTypeExtremeTypeEmptyList, Format: types.NumberFormatHex},
		max:        types.DataTypeExtreme{Type: types.DataTypeExtremeTypeEmptyList, Format: types.NumberFormatHex},
	},

You might need to adjust them, for example by adding zapMin and zapMax values if applicable.

return &EmptyLimit{}, nil
}

Loading