test: Multi-artifact-test: Do not build other distros #921
+22
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes CI time to blow up because in CI we split builds so that each distro is built in a separate job, however with the test the way it was before we ended up having to do additional work to build 2 other distros which takes up a bunch of extra time (fetch the images, prepare worker image) and space. The change, instead of building each target, now just builds the primary and asserts that none of the other distro's artifacts are in it. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the multi-artifact test to reduce CI build time by eliminating redundant distro builds. Instead of building all three distros (primary, secondary, and tertiary targets) to verify that target-level artifacts take precedence, the test now only builds the primary target and uses negative assertions (NotExist checks) to verify that artifacts from other targets are correctly excluded.
Key Changes
- Removed separate test runs for secondary and tertiary targets, reducing from 3 builds to 1 build per distro
- Modified artifact naming to use target-specific names (e.g., "from-mariner2") instead of generic names
- Added NotExist assertions for secondary, tertiary, and main artifacts to verify proper artifact precedence without building those targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes CI time to blow up because in CI we split builds so that each distro is built in a separate job, however with the test the way it was before we ended up having to do additional work to build 2 other distros which takes up a bunch of extra time (fetch the images, prepare worker image) and space.
The change, instead of building each target, now just builds the primary and asserts that none of the other distro's artifacts are in it.
Closes #903