Open
Conversation
mmussett
commented
Nov 27, 2024
mmussett
commented
- Support for symmetrical encryption/decryption using AES
- Support for asymmetrical encryption/decryption using RSA
- Support for hmac
Contributor
|
@abhide-tibco Can you review them? |
Contributor
abhijitWakchaure
left a comment
abhijitWakchaure
left a comment
There was a problem hiding this comment.
@mmussett I don't think you need to check logger.DebugEnabled().
The flogo logger will log your statements according the log level specified automatically.
Also I don't think those debug logs (entering and exiting function xxx) are adding any info to help debug things. Any error or panic stack will point us to the file and line number at which it failed.
abhide-tibco
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.