Remove JSON pre-processing for "SECRET:*" values#14
Remove JSON pre-processing for "SECRET:*" values#14debovema wants to merge 1 commit intoproject-flogo:masterfrom
Conversation
|
@mellistibco General question... should we support secrets only in properties? Or anywhere in the flogo.json. If its just used in properties, it makes the secret management easier and also easier to refer to in other places (you only have to set it once). The only question is it too burdensome if someone just has one secret? Would it be too much to ask to force them to use a property? |
|
I tend to think that we should support |
|
Does it assist in generating a "secret"? |
410ae00 to
a4df946
Compare
|
I think the secrets can be used anywhere (using the expression syntax =$property[some.secret] but should be declared only in properties for consistency reason. Even if the UI assists in generating a secret, it can do it in the properties section. Currently the "SECRET:..." patterns can be directly put in the activities configuration which is not a good practice IMHO. Other use case is the ability to use a plain-text property and change it later in the development to a secret one. Eventually, this PR is just about removing the duplicate processing of "SECRET:..." pattern, not about changing the secret resolving method (yet). |
This pre-processing is conflicting with secret.PropertyProcessor at
core/engine/secret/config.go
Line 33 in 98a1d79