Skip to content

Conversation

@mikemccracken
Copy link
Contributor

two CI changes:

  • switch to building just with golang 1.24 instead of both 1.22 and 1.23.
  • start running SLOW_TESTS on PRs. They were failing in nightlies for a week and no one noticed until we tried to build a release. Since the failure notifications don't go out to enough people, we should not rely on nightly builds to catch regressions in those tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

reenable slow tests for PR builds. Otherwise we don't get sufficient
notification if one breaks - the nightly workflows don't notify
everyone.

Signed-off-by: Michael McCracken <mikmccra@cisco.com>
Copy link
Contributor

@raharper raharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this started.

You also need to update the release and other workflow jobs which sort of expect two builds (any of them that use matrix strategy)

e.g: coverage.yaml

and I think most of those files select a version of go

it would be nice if we could set the version in a go.yaml or something and include that in all the places it wants to know a go version.

@mikemccracken
Copy link
Contributor Author

Thanks for getting this started.

You also need to update the release and other workflow jobs which sort of expect two builds (any of them that use matrix strategy)

e.g: coverage.yaml

and I think most of those files select a version of go

it would be nice if we could set the version in a go.yaml or something and include that in all the places it wants to know a go version.

Thanks, yeah I missed a few files there, derp.
I have moved them all to just reference one value and standardized on 1.24.

I am pretty sure that the actual users of the build.yaml that have a matrix don't need any change though, they just get run fewer times when there's one fewer dimension in the matrix.

No need to continue building multiple go versions.

Signed-off-by: Michael McCracken <mikmccra@cisco.com>
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.77%. Comparing base (577b538) to head (fcafbb1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #748      +/-   ##
==========================================
+ Coverage   51.83%   52.77%   +0.93%     
==========================================
  Files          59       59              
  Lines        6492     6492              
==========================================
+ Hits         3365     3426      +61     
+ Misses       2483     2424      -59     
+ Partials      644      642       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@raharper raharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup

@mikemccracken
Copy link
Contributor Author

Note that the specific go version doesn't really matter here, as long as it's post 1.21, because we end up building with what's in go.mod anyway. Having multiple values for go-version doesn't make sense now, they will all use the same actual toolchain version.

@mikemccracken mikemccracken merged commit 93e5d29 into project-stacker:main Dec 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants