-
Notifications
You must be signed in to change notification settings - Fork 37
ci: bump go to just 1.24 and run slow tests for PRs #748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: bump go to just 1.24 and run slow tests for PRs #748
Conversation
reenable slow tests for PR builds. Otherwise we don't get sufficient notification if one breaks - the nightly workflows don't notify everyone. Signed-off-by: Michael McCracken <mikmccra@cisco.com>
raharper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this started.
You also need to update the release and other workflow jobs which sort of expect two builds (any of them that use matrix strategy)
e.g: coverage.yaml
and I think most of those files select a version of go
it would be nice if we could set the version in a go.yaml or something and include that in all the places it wants to know a go version.
4e1fe56 to
d6f7831
Compare
Thanks, yeah I missed a few files there, derp. I am pretty sure that the actual users of the build.yaml that have a matrix don't need any change though, they just get run fewer times when there's one fewer dimension in the matrix. |
No need to continue building multiple go versions. Signed-off-by: Michael McCracken <mikmccra@cisco.com>
d6f7831 to
fcafbb1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #748 +/- ##
==========================================
+ Coverage 51.83% 52.77% +0.93%
==========================================
Files 59 59
Lines 6492 6492
==========================================
+ Hits 3365 3426 +61
+ Misses 2483 2424 -59
+ Partials 644 642 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
raharper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup
|
Note that the specific go version doesn't really matter here, as long as it's post 1.21, because we end up building with what's in |
two CI changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.