fix: bump build and ci go-version checks for publishing #749
Conversation
raharper
requested review from
hallyn,
mikemccracken,
rchamarthy,
rchincha,
smoser and
tych0
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
=======================================
Coverage 52.84% 52.84%
=======================================
Files 59 59
Lines 6492 6492
=======================================
Hits 3431 3431
Misses 2418 2418
Partials 643 643 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
raharper
force-pushed
the
fix/match-go-version-in-publish-path
branch
from
16a8e84 to
29204b4
Compare
|
Hrm, arm64 build is unhappy with erofs -- will debug this local. |
mikemccracken
left a comment
mikemccracken
left a comment
There was a problem hiding this comment.
it looks like the commit test: fixes for local and github building has a commit message that includes other commits' changes, and there's a commit called 'fold: ...' - were you meaning to squash here?
Yeah, not done yet -- I need build and coverage to pass. And coverage needs to be a copy of build.yaml, but only for one of the two jobs; so it's copy-pasta back and forth until it works. There has to be a better way |
Seemed to build fine locally; and now here. going to call it a cloud hiccup or something. |
|
Yay! builds locally on amd64 and arm64 and now cloud agrees. I'll rebase/squash and sign all of the commits. @mikemccracken any further feedback ? I plan to address the zot kill and switch to pidfile. |
|
no other feedback, lgtm, thanks for sorting all this out! |
Drop the go-version check in build and coverage when uploading binaries. We're only building with one version of go now. Signed-off-by: Ryan Harper <rharper@woxford.com>
Apply black python formatting to harness Signed-off-by: Ryan Harper <rharper@woxford.com>
Verify that we have the required env variables before starting the harness. This is primarily for offline testing but still useful in the github workflows Signed-off-by: Ryan Harper <rharper@woxford.com>
…il during priv run Signed-off-by: Ryan Harper <rharper@woxford.com>
- Format test/main.py with black python formatter
- Add skip_broken_tests and add this to bom test
- Currently the bom test isn't working so we'll skip until we
update the test for the current Centos image. Once that's
done we will change the test to fetch the Centos image via
sha256 and/or mirror it into the ghcr.io/project-stacker OCI
registry
- Add some debug around zot config starting
- Add checks to ensure exported variables that are required for the
test harness to run are present in the env before running the tests
- Check and dump env before starting bats suite
- Add zot_teardown calls to ensure that we've properly terminated zot
before attempting to start another one. The github runs saw errors
which looked like something already using port 8080 which is likely
a race with a zot being killed. Be more explicit and wait for it
to go away. Make use of pid file for simpler stopping
- Update/Add REGISTRY_SERVICE value to specify what registry OCI image
we're using and export this into the build environment
- Add support for copying and running REGISTRY_SERVICE when running
outside of github.
- Add start/stop_registry as convert tests uses registry to publish stuff
- Update publish.bats test to check if REGISTRY_SERVICE is running and
if not startup up the service. This handles the offline case where
registry is not provided by the build environment. For github where
service is running, it will skip the start/stop
Signed-off-by: Ryan Harper <rharper@woxford.com>
…pository Signed-off-by: Ryan Harper <rharper@woxford.com>
raharper
force-pushed
the
fix/match-go-version-in-publish-path
branch
from
72b9641 to
c0d28e8
Compare
3 participants
Drop the go-version check in build and coverage when uploading binaries. We're only building with one version of go now.
What type of PR is this?
bug
Which issue does this PR fix:
Publishing binaries
What does this PR do / Why do we need it:
Drop the goversion check when publishing build binaries and coverage data
If an issue # is not available please add repro steps and logs showing the issue:
Look at tag 1.1.4 and 1.1.5 action logs.
Testing done on this change:
None
Automation added to e2e:
none
Will this break upgrades or downgrades?
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.