Skip to content

feat: optimize GetNftSongs endpoint by fetching data in parallel #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wlara merged 1 commit into from
Jan 28, 2026
Merged

feat: optimize GetNftSongs endpoint by fetching data in parallel #719

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions newm-server/src/main/kotlin/io/newm/server/features/nftsong/repo/NftSongRepositoryImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,24 +7,27 @@ import io.newm.server.features.ethereum.repo.EthereumRepository
import io.newm.server.features.nftsong.model.NftChainMetadata
import io.newm.server.features.nftsong.model.NftSong
import io.newm.server.typealiases.UserId
import kotlinx.coroutines.async
import kotlinx.coroutines.coroutineScope

internal class NftSongRepositoryImpl(
private val cardanoRepository: CardanoRepository,
private val ethereumRepository: EthereumRepository
) : NftSongRepository {
override suspend fun getNftSongs(userId: UserId): List<NftSong> {
val nftSongs = mutableListOf<NftSong>()

nftSongs += cardanoRepository
.getWalletNftSongs(userId, includeLegacy = true, useDripDropz = false)
.map { it.toNftSong() }

nftSongs += ethereumRepository
.getWalletNftSongs(userId)
.map { it.toNftSong() }

return nftSongs
}
override suspend fun getNftSongs(userId: UserId): List<NftSong> =
coroutineScope {
val cardanoJob = async {
cardanoRepository
.getWalletNftSongs(userId, includeLegacy = true, useDripDropz = false)
.map { it.toNftSong() }
}
val ethereumJob = async {
ethereumRepository
.getWalletNftSongs(userId)
.map { it.toNftSong() }
}
cardanoJob.await() + ethereumJob.await()
}

private fun CardanoNftSong.toNftSong(): NftSong =
NftSong(
Expand Down