fix(txbuilder): include reference script bytes in fee calc#722
Merged
AndrewWestberg merged 1 commit intomasterfrom Feb 3, 2026
Merged
fix(txbuilder): include reference script bytes in fee calc#722AndrewWestberg merged 1 commit intomasterfrom
AndrewWestberg merged 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Cardano transaction builder where reference script bytes from source UTXOs (inputs being spent) were not being included in the transaction fee calculation. Previously, only reference scripts from reference inputs (read-only inputs) were accounted for in fees.
Changes:
- Added calculation of reference script bytes from source UTXOs
- Combined both reference script byte sources (reference inputs + source UTXOs) for complete fee calculation
- Bumped version from 0.13.0-SNAPSHOT to 0.13.1-SNAPSHOT to reflect the bug fix
- Added CBOR encoding/decoding documentation (unrelated to the core fix)
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| newm-tx-builder/src/main/kotlin/io/newm/txbuilder/TransactionBuilder.kt | Added logic to calculate and include reference script bytes from source UTXOs in fee calculation |
| build.gradle.kts | Version bump for bug fix release (0.13.0 → 0.13.1-SNAPSHOT) |
| .agent/skills/cbor-encoding-decoding/SKILL.md | Added AI agent documentation for CBOR encoding/decoding (unrelated to main fix) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.