Skip to content

Add a README.md#109

Closed
cgwalters wants to merge 1 commit intoprojectatomic:masterfrom
cgwalters:readme
Closed

Add a README.md#109
cgwalters wants to merge 1 commit intoprojectatomic:masterfrom
cgwalters:readme

Conversation

@cgwalters
Copy link
Member

Every project should have one really. Link to the man pages for now.

Every project should have one really.  Link to the man pages for now.
@cgwalters
Copy link
Member Author

Let's merge this after #108 so we can use Homu.

@rhatdan
Copy link
Member

rhatdan commented Mar 16, 2016

👍

@cgwalters
Copy link
Member Author

@rhatdan Want to try out Homu? Write in here: @ cgwalters-bot r+ 335ddba with no space between @ and the name.

@cgwalters
Copy link
Member Author

Although you're not actually a reviewer yet, let me fix that...

@cgwalters
Copy link
Member Author

fixed, also added @jwhonce

@rhatdan
Copy link
Member

rhatdan commented Mar 16, 2016

@cgwalters-bot r+335ddba

@rhatdan
Copy link
Member

rhatdan commented Mar 16, 2016

@cgwalters what was supposed to happen?

@cgwalters
Copy link
Member Author

@rhatdan Need a space between r+ and commit id

@rhvgoyal
Copy link
Collaborator

LGTM for the contents of PR.

@cgwalters
Copy link
Member Author

So something that's interesting here is the Travis build for the branch fails because it isn't rebased yet. However, the merge should work as that will automatically be rebased. We'll see, one of you guys want to approve?

@rhatdan
Copy link
Member

rhatdan commented Mar 16, 2016

@cgwalters-bot r+ 335ddba

@cgwalters-bot
Copy link

⌛ Testing commit 335ddba with merge c6f0553...

cgwalters-bot pushed a commit that referenced this pull request Mar 16, 2016
Every project should have one really.  Link to the man pages for now.

Pull request: #109
Approved by: rhatdan
@cgwalters-bot
Copy link

☀️ Test successful - travis

@rhatdan
Copy link
Member

rhatdan commented Mar 16, 2016

@cgwalters Pretty cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants