feat(DCP-2338): Add multiple_choice_with_unit instruction type#287
Merged
ajmalkhan-eng merged 5 commits intomainfrom Jan 28, 2026
Merged
Conversation
Adds support for a new instruction type that combines a value dropdown with a unit selector (e.g., height in CM/inches, weight in KG/lbs). Changes: - Add InstructionTypeMultipleChoiceWithUnit constant - Add UnitOption struct with Label and Value fields - Add unit_options and default_unit fields to instruction structs - Add validation requiring at least 2 unit options - Add comprehensive tests for the new instruction type
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…structions and corresponding test case
…llection creation
…ice-with-unit-instruction
script-this
previously approved these changes
Jan 28, 2026
Contributor
script-this
left a comment
script-this
left a comment
There was a problem hiding this comment.
Coupla suggestion otherwise LGTM. ✅
- Make default_unit required for multiple_choice_with_unit instructions - Extract workspace_id to top-level const with standard test ID format - Add test case for missing default_unit validation
script-this
approved these changes
Jan 28, 2026
ajmalkhan-eng
deleted the
DCP-2338-aitb-x-gmu-slice-2-cli-multiple-choice-with-unit-instruction
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for a new instruction type that combines a value dropdown with a unit selector (e.g., height in CM/inches, weight in KG/lbs).
Changes: