Cut 1.20.5 with the revert of #1424 (compareMetricFamilies)#1645
Cut 1.20.5 with the revert of #1424 (compareMetricFamilies)#1645bwplotka merged 2 commits intorelease-1.20from
Conversation
This reverts commit c7c7509.
Signed-off-by: bwplotka <bwplotka@gmail.com> # Conflicts: # CHANGELOG.md
ArthurSens
left a comment
ArthurSens
left a comment
There was a problem hiding this comment.
Reverting this change should NOT break (re-break) users who fixed their tests and switched to a new behaviour.
LGTM as long as the above was properly tested 😅!
|
Impressive that we've got a fifth patch release this time. As discussed in our call today, creating release candidates would improve everybody's life by a ton! Issue opened here: #1646 |
Yea, we only remove a check, so except this being more error-prone (we will reopen #1351), those who already did a work to adjust their test should be not impacted. However, for empirical test purposes, I kindly asked @krajorama to create a quick PR on Mimir with PR to double check (: EDIT: One test failed grafana/mimir#9624 (comment), but only because a different error message was produced. I think it's acceptable or not as smooth as I expected. Seems like still it's more annoying to keep this change vs revert, so proceeding. |
3 participants
I spoke to a few people (e.g. @dashpole @dgrisonnet @kakkoyun @ArthurSens @vesari @logicalhan), and it feels it might be easier for everyone to revert.
cc @machine424
Rationales:
I propose we revert this, and work on a long term solution. With the team we also discussed a way, where every client_golang release pipeline could propose an upgrade PR to a Kubernetes library that heavily depends on client_golang and check if the CI passes (compatibility check with a big user) -- to avoid similar issues in the future.