Open
Conversation
6782d2c to
6557753
Compare
Member
Author
|
Here's what a basic startup looks like: landingConfig := web.LandingConfig{
Name: "Node Exporter",
Description: "Prometheus Node Exporter",
Version: version.Info(),
}
toolkitConfig := toolkit.Config{
MetricsHandler: newHandler(!*disableExporterMetrics, *maxRequests, logger),
FlagConfig: toolkitFlags,
LandingConfig: landingConfig,
Logger: logger,
}
if err := toolkit.Run(toolkitConfig); err != nil {
level.Error(logger).Log("err", err)
os.Exit(1)
} |
Member
Author
|
Still some work to do, tests, etc. But what do you think of this concept so far? |
6557753 to
6ae4ad8
Compare
Member
Author
|
Ok, new example setup. There's an annoying chicken-and-egg problem with the MetricsHandler, since if we want to pass a logger to the handler, we need to |
02608de to
aa26aca
Compare
Member
Author
|
One solution, I could implement part of the node_exporter's handler into this. One of the nice features is that it would implement the |
Implement a top level package to make it easy to bootstrap an exporter. * Move the flag package to the top level. * Add support for `--web.telemetry-path` flag. Defaults to`/metrics`. * Add a self-check function to the web FlagConfig. Signed-off-by: SuperQ <superq@gmail.com>
aa26aca to
54b38e7
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a top level package to make it easy to bootstrap an exporter.
--web.telemetry-pathflag. Defaults to/metrics.