Add processing for route prefixes, external urls, and pprof mux#293
Open
kwilt wants to merge 5 commits intoprometheus:masterfrom
Open
Add processing for route prefixes, external urls, and pprof mux#293kwilt wants to merge 5 commits intoprometheus:masterfrom
kwilt wants to merge 5 commits intoprometheus:masterfrom
Conversation
…serving the pprof endpoints accessible on the landing page Signed-off-by: kwilt <kwilt@pm.me>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Ensure Path component of ExternalURL is formatted without trailing slashes, | ||
| // contains a leading slash, and is not empty | ||
| pathPrefix := strings.TrimRight(parsedExternalURL.Path, "/") | ||
| if pathPrefix != "" && !strings.HasPrefix(pathPrefix, "/") { |
Check warning
Code scanning / CodeQL
Bad redirect check Medium
Signed-off-by: kwilt <kwilt@pm.me>
Signed-off-by: kwilt <kwilt@pm.me>
Signed-off-by: kwilt <kwilt@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supporting pull request for prometheus/snmp_exporter#1335
Maybe this sucks, idk. I'm getting out of my comfort zone with this pull request lol. But I gave it a shot anyway. 😬
This is my attempt at moving a good chunk of the routing for the exporter into the landing page's codebase. In theory this could make a more cohesive experience across exporters and allow for easier development as most of the routing work is now done by using the LandingConfig struct.