Allow auth to be skipped for some paths#70
Open
darshanime wants to merge 1 commit intoprometheus:masterfrom
Open
Allow auth to be skipped for some paths#70darshanime wants to merge 1 commit intoprometheus:masterfrom
darshanime wants to merge 1 commit intoprometheus:masterfrom
Conversation
Signed-off-by: darshanime <deathbullet@gmail.com>
roidelapluie
reviewed
Nov 8, 2021
| func (u *webHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) { | ||
| // Check if path has auth excluded. | ||
| if _, ok := u.authExcludedPaths[r.URL.Path]; ok { | ||
| u.logger.Log("msg", "Bypassing auth, path in auth_excluded_paths", "path", r.URL.Path) |
Member
There was a problem hiding this comment.
I would leave logging out if this pull request until we figure out #63.
| if _, ok := u.authExcludedPaths[r.URL.Path]; ok { | ||
| u.logger.Log("msg", "Bypassing auth, path in auth_excluded_paths", "path", r.URL.Path) | ||
| u.handler.ServeHTTP(w, r) | ||
| return |
Member
There was a problem hiding this comment.
This should be below HTTP headers, and after we check that there are users set.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes prometheus/prometheus#9166
Signed-off-by: darshanime deathbullet@gmail.com