Updated LoadGenerator to use Configmap to query downloaded data.#811
Open
kushalShukla-web wants to merge 12 commits intoprometheus:masterfrom
Open
Updated LoadGenerator to use Configmap to query downloaded data.#811kushalShukla-web wants to merge 12 commits intoprometheus:masterfrom
kushalShukla-web wants to merge 12 commits intoprometheus:masterfrom
Conversation
…ed blocks. Signed-off-by: Kushal Shukla <kushalshukla110@gmail.com>
…d loadgen start and end time! Signed-off-by: Kushal Shukla <kushalshukla110@gmail.com>
Signed-off-by: Kushal Shukla <kushalshukla110@gmail.com>
Signed-off-by: Kushal Shukla <kushalshukla110@gmail.com>
2. Replaced images to prominfra docker registery. Signed-off-by: Kushal Shukla <kushalshukla110@gmail.com>
2. Removed Err and absoluteTime from the configState object. 3. Added flag package for debugging purpose and removed hard coded file path. Signed-off-by: Kushal Shukla <kushalshukla110@gmail.com>
kushalShukla-web
changed the title
kushalShukla-web
force-pushed
the
query-blockdata
branch
from
24cbf59 to
51c07a7
Compare
Signed-off-by: Kushal Shukla <kushalshukla110@gmail.com>
kushalShukla-web
force-pushed
the
query-blockdata
branch
from
51c07a7 to
6a56c11
Compare
kakkoyun
approved these changes
Feb 20, 2025
Contributor
Author
bboreham
requested changes
Apr 7, 2025
Member
bboreham
left a comment
bboreham
left a comment
There was a problem hiding this comment.
I think the basic idea is that someone will follow the instructions in #840 to create the blocksync-config ConfigMap.
However, as noted in my review of that PR, this has to be done by hand for each Prombench run, because they are all in a different namespace.
Comment on lines
+152
to
+153
| configMap: | ||
| name: blocksync-config |
Member
There was a problem hiding this comment.
Some extra scheme is needed to ensure this ConfigMap exists at the time this pod is started.
Contributor
Author
There was a problem hiding this comment.
Yeah, but the copy command will copy the ConfigMap into the PR namespace, so I don't think it's going to be an issue.
kushalShukla-web
force-pushed
the
query-blockdata
branch
2 times, most recently
from
d3304c2 to
5ff0876
Compare
modify if to switch statement
kushalShukla-web
force-pushed
the
query-blockdata
branch
from
5ff0876 to
c5b8c96
Compare
kushalShukla-web
changed the title
kushalShukla-web
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the previous PR #782, the Load Generator was using the bucket-config file from the Prometheus repository. Instead, it will now be stored as a ConfigMap inside the test-infra repository.