You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@psychobunny This implements reply/quote to blog comments. It also adds a label that scrolls to the replied comment (similar to NodeBB's one).
This is meant to be a basic implementation. It would be better to use a scrolling animation rather than scrollIntoView, for example.
(The font-size is different in the image due to some local CSS)
I included also a link to the user profile from username because on small resolutions the profile pictures are hidden (those are the links right now).
And by the way, I couldn't figure out how to access to <!-- IF posts.toPid --> (it can be a string or undefined) and {posts.parent.username}, so I had to create posts.isReply and posts.parentUsername. If you know a better way I can change it.
It seems that a reply to a purged post contains parent object without parent.username inside, so it's possible to remove the "reply-label" from those posts. However, in the case of replies to deleted posts (not purged), I think there is no way to differentiate from normal replies. /api/topic/id/... returns deleted posts as well, but the blog comments uses a different request which does not proportionate them.
I notice that in NodeBB itself a reply to a purged post will show the label without any content, what I guess it's a bug.
@revir Thanks! That's true, I forgot to hide the buttons when it's not logged in, my bad. I will try to update the PR when I have some time. I think this is still useful for some users even though I doubt it will be merged to the main repo at this point 😅
For other users, live demo here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@psychobunny This implements reply/quote to blog comments. It also adds a label that scrolls to the replied comment (similar to NodeBB's one).
This is meant to be a basic implementation. It would be better to use a scrolling animation rather than
scrollIntoView, for example.(The font-size is different in the image due to some local CSS)
I included also a link to the user profile from username because on small resolutions the profile pictures are hidden (those are the links right now).
And by the way, I couldn't figure out how to access to
<!-- IF posts.toPid -->(it can be a string or undefined) and{posts.parent.username}, so I had to createposts.isReplyandposts.parentUsername. If you know a better way I can change it.