feat: complete cmd #3
Conversation
Summary of ChangesHello @kooksee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a shell completion command (completion) for bash, zsh, and fish, which is a great enhancement for the CLI framework. It also includes a significant refactoring to remove configuration file support, simplifying the framework's configuration sources. While the overall changes are positive, I've found a critical syntax error in the zsh completion script generation that will prevent the code from compiling. I've provided a detailed comment and a suggested fix for this issue.
| buf.WriteString(`\ case $state in | ||
| subcmds) | ||
| local subcommands=(") | ||
| for _, child := range cmd.Children { | ||
| if !child.Hidden { | ||
| buf.WriteString(fmt.Sprintf("'%s:%s' ", child.Name(), child.Short)) | ||
| } | ||
| } | ||
| buf.WriteString(")") | ||
| buf.WriteString(" | ||
| _describe 'subcommands' subcommands | ||
| ;; | ||
| esac`) |
There was a problem hiding this comment.
This block of code for generating zsh subcommand handlers contains a syntax error. The for loop on line 240 is mixed with buf.WriteString calls in a way that is not valid Go syntax. The for loop is outside of any string literal, but it's surrounded by what appears to be shell script code, which will cause a compilation failure.
To fix this, you should construct the string of subcommands within the Go for loop and then write the complete case statement to the buffer.
| buf.WriteString(`\ case $state in | |
| subcmds) | |
| local subcommands=(") | |
| for _, child := range cmd.Children { | |
| if !child.Hidden { | |
| buf.WriteString(fmt.Sprintf("'%s:%s' ", child.Name(), child.Short)) | |
| } | |
| } | |
| buf.WriteString(")") | |
| buf.WriteString(" | |
| _describe 'subcommands' subcommands | |
| ;; | |
| esac`) | |
| buf.WriteString(`\ case $state in | |
| subcmds) | |
| local -a subcommands=( | |
| `) | |
| for _, child := range cmd.Children { | |
| if !child.Hidden { | |
| buf.WriteString(fmt.Sprintf(" '%s:%s'\n", child.Name(), child.Short)) | |
| } | |
| } | |
| buf.WriteString(` ) | |
| _describe 'subcommands' subcommands | |
| ;; | |
| esac`) |
No description provided.