Changes to allow gh-pages to work as a CDN where https is required#18
Open
kirkins wants to merge 7 commits intopubnub:masterfrom
Open
Changes to allow gh-pages to work as a CDN where https is required#18kirkins wants to merge 7 commits intopubnub:masterfrom
kirkins wants to merge 7 commits intopubnub:masterfrom
Conversation
use https instead of http
try using https for request
master changes into pages
Author
|
P.S. sorry for the other requests before I was ready. I meant to move changes from my master branch to gh-pages to test that it fixed my problem. |
Author
|
hmm you probably didn't want me to merge in that hot-fix to this pull request... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a few changes to the
eon.jsfile and thev/0.0.10/eon.jsfiles that allow me to use the gh-pages branch as a cdn for examples on JSfiddle.At example here:
If I use
https://pubnub.github.io/eon/lib/eon.jsinstead ofhttps://kirkins.github.io/eon/lib/eon.jsIt doesn't work because the default version always tries to use http.