Skip to content

Use database to find the task that was being run by a missing worker.#931

Open
dkliban wants to merge 1 commit intopulp:mainfrom
dkliban:db-cleanup
Open

Use database to find the task that was being run by a missing worker.#931
dkliban wants to merge 1 commit intopulp:mainfrom
dkliban:db-cleanup

Conversation

@dkliban
Copy link
Member

@dkliban dkliban commented Feb 8, 2026

ALso set app_lock on a task prior to setting to failed on cleanup.

Summary by Sourcery

Enhancements:

  • Refresh the 0033-Adds-redis-WORKER_TYPE patch file reference for Redis worker handling.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 8, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the worker cleanup logic so that when a worker is missing, the task it was running is looked up via the database instead of (or in addition to) in-memory/Redis tracking, and ensures an app_lock is acquired on the task before marking it as failed during cleanup.

File-Level Changes

Change Details Files
Route missing-worker task lookup through the database rather than relying solely on Redis or in-memory state.
  • Adjust the worker cleanup path to query the database for the task associated with a missing worker id.
  • Update any worker/task resolution helpers to accept or use database-backed lookups.
  • Align error handling and logging around missing workers with the new lookup source.
images/assets/patches/0033-Adds-redis-WORKER_TYPE.patch
Acquire an app_lock on a task before marking it failed during cleanup to prevent concurrent status updates.
  • Introduce or reuse an app_lock mechanism around task status mutation in the cleanup flow.
  • Wrap the missing-worker cleanup code that transitions a task to failed in an app_lock block.
  • Ensure that lock acquisition failures are handled safely and do not leave the task in an inconsistent state.
images/assets/patches/0033-Adds-redis-WORKER_TYPE.patch

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

ALso set app_lock on a task prior to setting to failed on cleanup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant