Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #215 +/- ##
==========================================
- Coverage 79.26% 78.19% -1.08%
==========================================
Files 15 15
Lines 1548 1605 +57
==========================================
+ Hits 1227 1255 +28
- Misses 321 350 +29
☔ View full report in Codecov by Sentry. |
|
I am fine with this is theory but obviously CI should be passing before it is merged. |
|
👋 @bastelfreak This branch is in your fork of the repository. Is it okay to push attempts to fix CI to it? If so I guess we can't amend the branch to fix broken fixes, in this case how should we proceed? Otherwise, what should we do (open new PR based on this one)? |
|
you have full permissions in my branch and can also do force pushes/modify history. Feel free to hack on it! |
|
The rest of the failures are caused by:
|
Fixnum was an implementation detail of older Ruby versions and have been the same as Integer since Ruby 2.4. Ruby 3.2 stopped to provide this "alias" so use the proper class name.
|
Thanks @bastelfreak I missed that you had this PR and it's been superseded by #262 I'll do a release of beaker-puppet on Monday. |
No description provided.