Add task notify support to CrossplatformThread#13
Open
Ryan4253 wants to merge 1 commit intopurduesigbots:masterfrom
Open
Add task notify support to CrossplatformThread#13Ryan4253 wants to merge 1 commit intopurduesigbots:masterfrom
Ryan4253 wants to merge 1 commit intopurduesigbots:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adds notify() to the CrossplatformThread, which does nothing for std::thread and is a wrapper around pros::c::notify_take(task) when a pros task is used
Motivation
This allows code that uses task notification to be testable locally by preventing having to interface with pros when notify needs to be called.
Possible Drawbacks
None
Verification Process
Ran it on the bot .The code should be simple enough too.
Applicable Issues
N/A