Use Node.js native sqlite instead of better-sqlite3 #1357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Maybe it is better to move to nodejs build-in sql support https://nodejs.org/api/sqlite.html (available from Node 22) Spago next is a new tool and still not widely used so I don't think that there need to worry about old node version and ignore node platform development. |
Contributor
Author
|
@wclr sure, let's get some buy-in first from the maintainers and then we can also go that route. Main motivation is to avoid having to rebuild spago for different node versions. |
Replaces @libsql/client with Node.js's built-in node:sqlite module. Changes: - Replace libsql/turso client with DatabaseSync from node:sqlite - Remove @libsql/client dependency from package.json - Remove --external:@libsql/client from bundler config - Add NODE_NO_WARNINGS=1 to suppress experimental sqlite warnings - Add explicit directory creation (was built-in with better-sqlite3) - Use db.exec() for PRAGMA statements (db.pragma() doesn't exist) - Wrap all operations in Promise.resolve() for FFI compatibility Benefits: - Zero external dependencies for SQLite - Simpler implementation (no remote database support needed) - Nearly identical API to the original better-sqlite3 version All tests pass (235/239, same as baseline - 4 pre-existing failures unrelated to SQLite changes).
i-am-the-slime
changed the title
- Add missing getMetadataImpl export (was declared in FFI but not exported) - Use --no-warnings flag to suppress experimental SQLite warnings - In bin/index.dev.js shebang for direct execution - In test/Prelude.purs when spawning spago in tests - Add trailing newline to Db.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace better-sqlite3 with Node.js's built-in
node:sqlitemodule to avoid native compilation dependencies.Changes
@libsql/client(turso) with Node.js nativenode:sqlitemoduleBenefits
Testing
All tests pass: 235/239 (same as baseline - 4 pre-existing failures unrelated to SQLite changes)
Note
The
node:sqlitemodule is marked as experimental in Node.js, but it's stable enough for our use case. The warning is suppressed in the CLI entry point.