Skip to content

Issue 264 - Use updated extension for demo app on PRs #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huntharo merged 2 commits into from
Jan 6, 2025
Merged

Issue 264 - Use updated extension for demo app on PRs #265

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a51e1a
Issue-256 - Extension - Add SHA tag for PR
huntharo Jan 5, 2025
457976d
Issue-256 - Demo-App - Use PR SHA for extension
huntharo Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,8 +414,9 @@ jobs:
tags: |
enable=${{ github.event_name == 'release' }},type=raw,value=latest
type=ref,event=branch
type=ref,event=pr
type=semver,pattern={{version}}
type=ref,event=pr
type=ref,event=pr,suffix=-{{sha}}
labels: |
org.opencontainers.image.source=${{ github.event.repository.html_url }}
org.opencontainers.image.revision=${{ github.sha }}
Expand Down Expand Up @@ -481,12 +482,16 @@ jobs:
org.opencontainers.image.source=${{ github.event.repository.html_url }}
org.opencontainers.image.revision=${{ github.sha }}

- name: Get Git SHA
id: git-sha
run: echo "sha_short=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT

- name: Compute Versions
id: version
run: |
if [ -n "${{ github.event.pull_request.number }}" ]; then
IMAGE_TAG="pr-${{ github.event.pull_request.number }}"
echo "imageTag=pr-${{ github.event.pull_request.number }}" >> $GITHUB_OUTPUT
echo "imageTag=pr-${{ github.event.pull_request.number }}-${{ steps.git-sha.outputs.sha_short }}" >> $GITHUB_OUTPUT
echo "PR_SUFFIX=-pr-"${{ github.event.pull_request.number }} >> $GITHUB_ENV
else
TAG_OR_BRANCH=$(echo $GITHUB_REF | sed -e 's|refs/tags/v||' -e 's|refs/heads/||')
Expand Down Expand Up @@ -531,10 +536,6 @@ jobs:
with:
registry-type: private

- name: Get Git SHA
id: git-sha
run: echo "sha_short=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT

- name: Build and push Docker image for arm64
run: |
docker buildx build --platform linux/arm64 --file ./DockerfileLambdaDemoApp \
Expand Down
Loading