Open
Conversation
the utcnow assumtion in the test failed for dates after 2038-01-19 because the date wraps back to 1902 This bug was found while working on reproducible builds for openSUSE.
bmwiedemann
force-pushed
the
fix2038
branch
from
6f9e8a7 to
294fc77
Compare
CoolCat467
approved these changes
Jan 26, 2023
CoolCat467
left a comment
CoolCat467
left a comment
There was a problem hiding this comment.
Yes, simply using 64 bit integers instead will work for the next 2 billion years
Author
|
Hi, do you merge this patch or make some alternative? |
CoolCat467
reviewed
Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug was found while working on reproducible builds for openSUSE.
Background:
As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future.
The usual offset is +16 years, because that is how long I expect some software will be used in some places.
This showed up failing tests in our package build.
See https://reproducible-builds.org/ for why this matters.