Set window gamma ramp and set window brightness can fail#283
Merged
a-hurst merged 2 commits intopy-sdl:masterfrom Mar 20, 2025
Merged
Conversation
Member
|
Looks good to me, thanks! The test failure looks like it's due to me just updating the pysdl2-dll binary package since your last PR (serves me right for not pinning the package version in CI runners), so I'll fix that separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDL_SetWindowBrightnessandSDL_SetWindowGammaRampare not available anymore in SDL3,so fail when used in sdl2-compat.
PR Description
Merge Checklist
closes #<issue-number>to automatically close an issue