Skip to content

Conversation

@dbarnett
Copy link

@dbarnett
Copy link
Author

Please LMK if you prefer to use the __all__ approach instead, and any other important symbols I should also export while I'm in here.

Copy link

@htgoebel htgoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds semantic understood by mypy only. I've never seen this and without your link to teh mypy documentation I'd say, this is bad code.

__all__ is much more commonly used and much more understood. I suggest using that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix type errors by explicitly exporting vobject.readComponents?

2 participants