Extract _prepare_unload() helper into BaseCursor#677
Closed
laughingman7743 wants to merge 1 commit intofeature/669-with-fetch-mixinfrom
Closed
Extract _prepare_unload() helper into BaseCursor#677laughingman7743 wants to merge 1 commit intofeature/669-with-fetch-mixinfrom
laughingman7743 wants to merge 1 commit intofeature/669-with-fetch-mixinfrom
Conversation
The UNLOAD preparation block (validate s3_staging_dir, wrap query with UNLOAD statement) was duplicated character-for-character across 9 cursor files. This consolidates the logic into a single _prepare_unload() method on BaseCursor, which is pure computation and works for all cursor families (sync, async, aio). Also adds return type annotation to Formatter.wrap_unload() to satisfy mypy. Closes #670 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
s3_staging_dir, wrap query viaFormatter.wrap_unload()) into a single_prepare_unload()method onBaseCursorFormatter.wrap_unload()to satisfy mypyNet change: +48 / -119 lines (71 lines removed).
Closes #670
Test plan
make fmtpassesmake chkpasses (ruff lint + format + mypy)make testpasses (requires AWS credentials)🤖 Generated with Claude Code