Skip to content

[enhancement] +share card details, and post inspector instructions #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
surfaceowl merged 1 commit into from
May 25, 2025
Merged

[enhancement] +share card details, and post inspector instructions #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion PyBay/templates/layout.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@
<title>PyBay 2025 - 10th Annual Bay Area Python Dev Conference - {% block title %}{% endblock %}</title>
<meta name="title" content="PyBay 2025 - 10th Annual Bay Area Python Dev Conference">
<meta name="description" content="10th Annual Python developer conference - longest running on the US West Coast. Join us in San Francisco!">

<meta name="author" content="Bay Area Python Association (BAPyA)">
Copy link

Copilot AI May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ensure author metadata is recognized by Open Graph consumers, consider adding <meta property="article:author" content="Bay Area Python Association (BAPyA)"> alongside the standard author meta tag.

Suggested change
<meta name="author" content="Bay Area Python Association (BAPyA)">
<meta name="author" content="Bay Area Python Association (BAPyA)">
<meta property="article:author" content="Bay Area Python Association (BAPyA)">

Copilot uses AI. Check for mistakes.
<!-- published time --> <!-- most sites will parse the date correctly if we leave time blank -->
Copy link

Copilot AI May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider consolidating these two inline comments into a single, more descriptive comment block above the article:published_time tag to maintain consistent commenting style.

Suggested change
<!-- published time --> <!-- most sites will parse the date correctly if we leave time blank -->
<!-- Published Time Metadata -->
<!-- This tag specifies the publication date of the article. -->
<!-- Most sites will parse the date correctly even if the time is left blank. -->

Copilot uses AI. Check for mistakes.
<meta property="article:published_time" content="2025-05-25">
<!-- Open Graph / Facebook --> <!-- this is what Facebook and other social websites will draw on -->
<meta name="og:type" property="og:type" content="website">
<meta name="og:url" property="og:url" content="{{ site.get('/')|url }}">
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- Make changes to code
- Check for errors; check that the site displays correctly in multiple browsers and mobile.
- Inspect with other support tools (e.g., Lighthouse, https://metatags.io/ for share cards, social metadata. etc.) make sure share cards display correctly and metadata is correct.
- LinkedIn Post Inspector (https://www.linkedin.com/post-inspector/inspect/) gives a more detailed view of errors, but does not work through redirects. You can make your GitHub Codespace Public and test (same box as 'open browser' link when you first run it), and also check after changes are in production.
Copy link

Copilot AI May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] This bullet combines two distinct instructions; consider splitting it into two separate list items—one introducing the LinkedIn Post Inspector tool and another describing how to test via a public Codespace—to improve readability.

Suggested change
- LinkedIn Post Inspector (https://www.linkedin.com/post-inspector/inspect/) gives a more detailed view of errors, but does not work through redirects. You can make your GitHub Codespace Public and test (same box as 'open browser' link when you first run it), and also check after changes are in production.
- Use LinkedIn Post Inspector (https://www.linkedin.com/post-inspector/inspect/) to get a detailed view of errors in share cards and metadata. Note that it does not work through redirects.
- To test share cards and metadata via LinkedIn Post Inspector, you can make your GitHub Codespace public (use the same box as the 'open browser' link when you first run it). Additionally, check the site after changes are in production.

Copilot uses AI. Check for mistakes.
- Commit and push to your branch (`git add -u`) (`git commit -m "your update descriptions here"`) and (`git push`)
- Open PR and request review before merging with the main branch
- After comments and requested fixes are made, merge PR to the main branch.
Expand Down