Skip to content

Comments

Apply more ruff rules#633

Open
DimitriPapadopoulos wants to merge 4 commits intopypa:mainfrom
DimitriPapadopoulos:PERF
Open

Apply more ruff rules#633
DimitriPapadopoulos wants to merge 4 commits intopypa:mainfrom
DimitriPapadopoulos:PERF

Conversation

@DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Aug 24, 2024

No description provided.

@codecov
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.54%. Comparing base (8b6fa74) to head (245c243).

Files with missing lines Patch % Lines
src/wheel/_bdist_wheel.py 0.00% 1 Missing ⚠️
src/wheel/macosx_libfile.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #633      +/-   ##
==========================================
- Coverage   52.63%   52.54%   -0.09%     
==========================================
  Files          14       14              
  Lines        1121     1119       -2     
==========================================
- Hits          590      588       -2     
  Misses        531      531              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DimitriPapadopoulos DimitriPapadopoulos changed the title Apply ruff/Perflint rule PERF401 Apply more ruff rules Aug 24, 2024
@agronholm
Copy link
Contributor

I'm not seeing any changes to pyproject.toml?

@agronholm
Copy link
Contributor

May I ask what prompted this change?

@DimitriPapadopoulos
Copy link
Contributor Author

I just tried to apply some rules that raised a few valid issues in other projects.

PIE810 Call `endswith` once with a `tuple`
FLY002 Consider f-string instead of string join
PERF401 Use a list comprehension to create a transformed list
@agronholm
Copy link
Contributor

May I ask what your interest is in pushing more Ruff rules to this project, especially given how I've (deliberately) made it far less relevant in the packaging ecosystem than it was in the past?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants