Implementation of Will's GP into pyrokinetics#509
Open
FelixWattsYork wants to merge 112 commits intounstablefrom
Open
Implementation of Will's GP into pyrokinetics#509FelixWattsYork wants to merge 112 commits intounstablefrom
FelixWattsYork wants to merge 112 commits intounstablefrom
Conversation
…complaining about typing
…e normalisation issues.
….0, can happen in adiabatic electron sims
Added functionality to store the runfile_dict in a pyroscan in json, and load it back at a later point. no a breaking change but default dictionaty format for runfile_dict is now a string to allow for json saving
* Fix GENE MXH setting of s_delta/s_zeta and correct Bgeo/B0 calc * Add check in case dsndr/dcdr are just 0.0 in gene input * flake8 fix * Handling of the cases where `minor_r` is not set properly * [skip ci] Apply black changes * Triggering of automatic testing --------- Co-authored-by: physycola <toby.adkins1@gmail.com> Co-authored-by: physycola <physycola@users.noreply.github.com>
Extended Some very basic tests and got read without fields and fluxes working in a very limtied sense
…d a bit more robust, still not coded particuarly well
…S2_GP this is a merge
working
working
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not Ready for Merge!
Contains and Implementation of Will's GP model based on GS2 for calculating linear instability growth rates. Callable as a diagnostic for pyro or pyroscan objects
Also includes
Issues
In general this branch is long way from being ready to be merged. The code quality is poor, it lacks unit tests, and a number of features are not robust. In addition Will is currently rebuilding the GS2 simulations necessary for an accurate prediction of beta prime stabilization.
The point of this PR is to gain feedback about general code quality/structure and about the nature of the implementation. In particular how the saturation rule is attached to the GP. This is my first major code addition so any Feedback would be greatly appreciated!!!!