Open
Conversation
…ust the answer. Need to fully compare to flux to see if the implementation is correct
bpatel2107
reviewed
Feb 17, 2026
Collaborator
bpatel2107
left a comment
bpatel2107
left a comment
There was a problem hiding this comment.
I don't think we should pass an xarray dataset inside each individual gk_code file as the other data (fields, fluxes, moments) aren't treated like that.
I think we just pass it a numpy array of the Jacobian and let gk_output.py convert it to the appropriate format. Otherwise we add a bunch of xarray imports that aren't really necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load GK_Output now loads the Jacobian (in terms of R) for each theta for Gyrokinetic simulations. This allows one to accurately integrate over a flux surface, as can be necessary for field data