Skip to content

Comments

Improving pyroscan error handling#529

Merged
physycola merged 1 commit intounstablefrom
enchancement/improve_pyroscan_error_handling
Feb 24, 2026
Merged

Improving pyroscan error handling#529
physycola merged 1 commit intounstablefrom
enchancement/improve_pyroscan_error_handling

Conversation

@physycola
Copy link
Collaborator

Modified error handling to cleanly handle the first point in a pyroscan not loading properly

@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

❌ Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.91%. Comparing base (0d89cea) to head (6ee2451).
⚠️ Report is 65 commits behind head on unstable.

Files with missing lines Patch % Lines
src/pyrokinetics/pyroscan.py 0.00% 22 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #529      +/-   ##
============================================
- Coverage     81.55%   80.91%   -0.65%     
============================================
  Files            56       57       +1     
  Lines         12032    12517     +485     
============================================
+ Hits           9813    10128     +315     
- Misses         2219     2389     +170     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@physycola physycola requested a review from bpatel2107 February 23, 2026 22:19
Copy link
Collaborator

@bpatel2107 bpatel2107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh this is clever, I like!

@physycola physycola merged commit 459ca65 into unstable Feb 24, 2026
18 of 19 checks passed
@physycola physycola deleted the enchancement/improve_pyroscan_error_handling branch February 24, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants