Add user_properties to test case report#59
Open
kurt-cb wants to merge 9 commits intopytest-dev:masterfrom
Open
Add user_properties to test case report#59kurt-cb wants to merge 9 commits intopytest-dev:masterfrom
kurt-cb wants to merge 9 commits intopytest-dev:masterfrom
Conversation
Author
|
steps to reproduce:
|
Author
|
this PR addresses #60 by updating the properties from the standard record_property builtin fixture. |
tonybaloney
approved these changes
Oct 16, 2022
added 8 commits
January 6, 2023 16:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of creating a new API for adding properties, capture pytest user_properties. This removes the need for a special fixture and also works correctly with pytest-parallel
Setting internal variables with the record_nunit_property is non-functional in pytest-parallel as the modifications are done in a different process (nunit_xml is a sub-process copy, so the changes are lost). user_properties are reported and re-synchronized with the main process via the test_report. This is a better location for test case properties IMHO.