-
Notifications
You must be signed in to change notification settings - Fork 2.4k
release: bump version to 2.3.0 #10695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's GuideRelease prep for Poetry 2.3.0: adds a full 2.3.0 changelog entry, updates comparison links, and bumps the project version in pyproject.toml while keeping poetry-core on a git dependency with a TODO to pin to the released core version. Flow diagram for Poetry 2.3.0 release preparation stepsflowchart TD
Start[Start release prep] --> Update_changelog[Add 2.3.0 section to CHANGELOG]
Update_changelog --> Update_links[Update Unreleased compare link to 2.3.0...main]
Update_links --> Bump_version[Bump project version in pyproject.toml to 2.3.0]
Bump_version --> Keep_core_git[Keep poetry-core as git dependency with TODO to pin]
Keep_core_git --> End[Release metadata ready]
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've found 2 issues, and left some high level feedback:
- The
# TODOplaceholder at the end of the 2.3.0 changelog section should be either filled in with its intended content (e.g., a brief summary of poetry-core changes) or removed before release. - The
poetry-coredependency inpyproject.tomlis still pointing togit+https://github.com/python-poetry/poetry-core.gitwith a TODO comment; consider updating this to the released 2.3.0 tag as part of the version bump to keep the release self-contained.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `# TODO` placeholder at the end of the 2.3.0 changelog section should be either filled in with its intended content (e.g., a brief summary of poetry-core changes) or removed before release.
- The `poetry-core` dependency in `pyproject.toml` is still pointing to `git+https://github.com/python-poetry/poetry-core.git` with a TODO comment; consider updating this to the released 2.3.0 tag as part of the version bump to keep the release self-contained.
## Individual Comments
### Comment 1
<location> `CHANGELOG.md:28-30` </location>
<code_context>
+- Improve managing free-threaded Python versions with `poetry python` ([#10606](https://github.com/python-poetry/poetry/pull/10606)).
+- Prefer JSON API to HTML API in legacy repositories ([#10672](https://github.com/python-poetry/poetry/pull/10672)).
+- When running `poetry init`, only add the readme field in the `pyproject.toml` if the readme file exists ([#10679](https://github.com/python-poetry/poetry/pull/10679)).
+- Raise an error if no hash can be determined for any distribution link of package ([#10673](https://github.com/python-poetry/poetry/pull/10673)).
+- Require `dulwich>=0.25.0` ([#10674](https://github.com/python-poetry/poetry/pull/10674)).
+
</code_context>
<issue_to_address>
**issue (typo):** Missing article in "distribution link of package"; consider "of a package" or "of the package".
Depending on whether this is generic or about a specific package, choose either "for any distribution link of a package" or "for any distribution link of the package."
```suggestion
- When running `poetry init`, only add the readme field in the `pyproject.toml` if the readme file exists ([#10679](https://github.com/python-poetry/poetry/pull/10679)).
- Raise an error if no hash can be determined for any distribution link of a package ([#10673](https://github.com/python-poetry/poetry/pull/10673)).
- Require `dulwich>=0.25.0` ([#10674](https://github.com/python-poetry/poetry/pull/10674)).
```
</issue_to_address>
### Comment 2
<location> `CHANGELOG.md:44` </location>
<code_context>
+- Fix an issue where `poetry publish` used the metadata of the project instead of the metadata of the build artifact ([#10624](https://github.com/python-poetry/poetry/pull/10624)).
+- Fix an issue where `poetry env use` just used another Python version instead of failing when the requested version was not supported by the project ([#10685](https://github.com/python-poetry/poetry/pull/10685)).
+- Fix an issue where `data-dir` and `python.installation-dir` could not be set ([#10595](https://github.com/python-poetry/poetry/pull/10595)).
+- Fix an issue where Python and pip executables where not correctly detected on Windows ([#10645](https://github.com/python-poetry/poetry/pull/10645)).
+- Fix an issue where invalid template variables in `virtualenvs.prompt` caused an incomprehensible error message ([#10648](https://github.com/python-poetry/poetry/pull/10648)).
+
</code_context>
<issue_to_address>
**issue (typo):** Typo: the second "where" should be "were".
In this bullet, "executables where not correctly detected" should read "executables were not correctly detected".
Suggested implementation:
```
- Fix an issue where `data-dir` and `python.installation-dir` could not be set ([#10595](https://github.com/python-poetry/poetry/pull/10595)).
- Fix an issue where Python and pip executables were not correctly detected on Windows ([#10645](https://github.com/python-poetry/poetry/pull/10645)).
```
In your local version of `CHANGELOG.md`, if the bullet already exists but reads:
`- Fix an issue where Python and pip executables where not correctly detected on Windows (...)`
then instead of inserting a new line, you should edit that existing line to replace `where not` with `were not`.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
c43e94c to
90c8577
Compare
Added
pylock.tomlfiles withpoetry-plugin-export(#10677).requires-poetrybefore any other validation (#10593).project.readmewhen runningpoetry check(#10604).poetry cache clearoptional (#10627).--no-cachesolves an issue (#10585).poetry initwhen tryingpoetry newfor an existing directory (#10563).poetry publish --skip-existingfor new Nexus OSS versions (#10603).poetry debug info(#10588).Changed
installer.re-resolvefromtruetofalse(#10622).poetry.utils._compat.metadata, which is sometimes used in plugins, in favor ofimportlib.metadata(#10634).poetry python(#10606).poetry init, only add the readme field in thepyproject.tomlif the readme file exists (#10679).dulwich>=0.25.0(#10674).Fixed
poetry removedid not work for PEP 735 dependency groups withinclude-groupitems (#10587).poetry removecaused danglinginclude-groupreferences in PEP 735 dependency groups (#10590).poetry adddid not work for PEP 735 dependency groups withinclude-groupitems (#10636).poetry-plugin-export(#10667).poetry publishused the metadata of the project instead of the metadata of the build artifact (#10624).poetry env usejust used another Python version instead of failing when the requested version was not supported by the project (#10685).data-dirandpython.installation-dircould not be set (#10595).virtualenvs.promptcaused an incomprehensible error message (#10648).Docs
~/.netrcfor Poetry credential configuration (#10630).packagesare automatically detected (#10680).poetry-core (
2.3.0)TODO