Skip to content

[CI] Use Python 3.12 for third-party stubtest #12847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srittau wants to merge 14 commits into from
Closed

[CI] Use Python 3.12 for third-party stubtest #12847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
886960f
Use Python 3.12 for third-party checks
srittau Oct 18, 2024
18603ac
Use Python 3.12 for third-party checks
srittau Oct 18, 2024
faf72b8
Merge branch 'main' into py-3.12-third-party
srittau Oct 18, 2024
70b5f23
Disable stubtest for atheris
srittau Oct 18, 2024
33d4131
Skip playsound
srittau Oct 18, 2024
cf17d6d
Skip stubtest for boto
srittau Oct 18, 2024
0f1fe4d
Update stubtest_allowlist.txt for Python 3.12
srittau Oct 18, 2024
0e788a4
Update stubtest_allowlist.txt for Python 3.12
srittau Oct 18, 2024
a80840d
Link atheris PR
srittau Oct 18, 2024
c519795
Merge branch 'main' into py-3.12-third-party
srittau Oct 19, 2024
794cef7
Merge branch 'main' into py-3.12-third-party
srittau Oct 21, 2024
a9c62fb
Merge branch 'main' into py-3.12-third-party
srittau Oct 21, 2024
4be6751
Merge branch 'main' into py-3.12-third-party
srittau Dec 3, 2024
96f9e07
Skip gdb stubtest
srittau Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/daily.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
# TODO: Use Python 3.12. As of 2024-03-08, several third-party
# packages fail to install with Python 3.12.
python-version: "3.11"
python-version: "3.12"
cache: pip
cache-dependency-path: |
requirements-tests.txt
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/stubtest_third_party.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-python@v5
with:
# TODO: Use Python 3.12. As of 2024-03-08, several third-party
# packages fail to install with Python 3.12.
python-version: "3.11"
python-version: "3.12"
cache: pip
cache-dependency-path: |
requirements-tests.txt
Expand Down
3 changes: 3 additions & 0 deletions stubs/atheris/METADATA.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,6 @@ partial_stub = true

[tool.stubtest]
ignore_missing_stub = true
# TODO: Does not compile with Python 3.12 as of 2024-10-18 (release 2.3.0).
# https://github.com/google/atheris/pull/60
skip = true
13 changes: 13 additions & 0 deletions stubs/gdb/METADATA.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,16 @@ extra_description = """\
[tool.stubtest]
platforms = ["linux"]
apt_dependencies = ["gdb"]
# stubtest fails for unknown reasons after upgrading to use Python 3.12:
#
# Traceback (most recent call last):
# File "/tmp/stubtest-4m851njl/gdb_stubtest.py", line 22, in <module>
# from mypy.stubtest import main
# File "/tmp/stubtest-4m851njl/lib/python3.12/site-packages/mypy/stubtest.py", line 30, in <module>
# from pathlib import Path
# File "/usr/lib/python3.12/pathlib.py", line 19, in <module>
# from urllib.parse import quote_from_bytes as urlquote_from_bytes
# File "/usr/lib/python3.12/urllib/parse.py", line 36, in <module>
# import math
# ModuleNotFoundError: No module named 'math'
Copy link
Collaborator

@Avasam Avasam Mar 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From all the googling I did. This seems to always come back to a python build/installation issue. I know we do a bit a special setup to run stubtest on gdb. Maybe there's something wrong with the Python 3.12 version from actions/setup-python. We could raise an issue / request support if we can provide an MRE"

Anyway with #13582 being merge this is already skipped, so I wouldn't consider it a blocker anymore. You can probably merge both comments.

skip = true
4 changes: 0 additions & 4 deletions stubs/openpyxl/@tests/stubtest_allowlist.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,3 @@ openpyxl.worksheet.smart_tag.CellSmartTagPr.__init__
openpyxl.worksheet.smart_tag.CellSmartTags.__init__
openpyxl.worksheet.table.TableColumn.__init__
openpyxl.worksheet.table.XMLColumnProps.__init__

# Inherited from the stdlib, where we lie about the presence
# of this method in order to mark it as deprecated.
openpyxl.xml.functions.Element.__bool__
3 changes: 0 additions & 3 deletions stubs/requests/@tests/stubtest_allowlist.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,3 @@
requests.packages.mod
requests.packages.package
requests.packages.target

# Alias for builtins.bytes
requests.compat.bytes.__buffer__
Loading