Use pydantic models for configuration #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I intend to bring this in parallel to functioning previous code.
Need to use the PEP621 TOML badge
Still cleaning up but it's definitely a much better approach. Less code (and will shrink more). Improved logging with YAML (not Python dict pprint) and emojis. * Examples all render fine * Variants broken if pages not defined in document just variants * Need to fix all tests for new class structures * Review all TODO/FIXME before merging (esp. for variants, clumsy/messy) * Tidy up, check __all__, try/except, customize pydantic error messages
Major reshuffling. Tests are all passing again.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pydantic seems a natural fit for our purposes.
This is a major refactoring.