Skip to content

cursor in password field using set_cursor_position #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pythops merged 3 commits into from
Dec 1, 2025
Merged

cursor in password field using set_cursor_position #97

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81d695d
cursor in password field using set_cursor_position
otomist Dec 1, 2025
090a617
increase password field width
otomist Dec 1, 2025
6e566e4
use safer subtraction (saturatng_sub) and format
otomist Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 29 additions & 12 deletions src/mode/station/auth/psk.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,10 @@ impl Psk {
let area2 = Layout::default()
.direction(Direction::Horizontal)
.constraints([
Constraint::Percentage(20),
Constraint::Length(2),
Constraint::Fill(1),
Constraint::Length(5),
Constraint::Percentage(20),
Constraint::Length(2),
])
.flex(ratatui::layout::Flex::Center)
.split(chunks[2]);
Expand All @@ -114,16 +114,18 @@ impl Psk {
.style(Style::default().fg(Color::White))
.block(Block::new().padding(Padding::uniform(1)));

let passkey = Paragraph::new({
if self.show_password {
self.passphrase.value().to_string()
} else {
"*".repeat(self.passphrase.value().len())
}
})
.alignment(Alignment::Center)
.style(Style::default().fg(Color::White))
.block(Block::new().style(Style::default().bg(Color::DarkGray)));
let passphrase_str = if self.show_password {
self.passphrase.value().to_string()
} else {
"*".repeat(self.passphrase.value().len())
};

let pass_len = passphrase_str.len();

let passkey = Paragraph::new(passphrase_str)
.alignment(Alignment::Center)
.style(Style::default().fg(Color::White))
.block(Block::new().style(Style::default().bg(Color::DarkGray)));

let show_password_icon = if self.show_password {
Text::from("󰈈 ").centered()
Expand All @@ -143,6 +145,21 @@ impl Psk {
);
frame.render_widget(text, text_area);
frame.render_widget(passkey, passkey_area);

let inner_width = passkey_area.width.saturating_sub(2) as usize;
let pad_left = if inner_width > pass_len {
inner_width.saturating_sub(pass_len) / 2
} else {
0
};

let visual_cursor = self.passphrase.visual_cursor().min(pass_len);

let x_in_inner = pad_left + visual_cursor;

let cursor_x = passkey_area.x + 1 + x_in_inner as u16;
frame.set_cursor_position((cursor_x, passkey_area.y));

frame.render_widget(show_password_icon, show_password_area);
}
}