Adjust value assignment logic in event.py #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #224
Somehow I (and some others) got a "Verkaufsorder"/Sale with the attribute
Which caused an error because the parser explicitly checked for
value != 0.0.This pull request removes the explicit check for zero values when parsing the
amount.valuefield, so a value of0.0will now be considered valid instead of being replaced withNone.That being said I am not sure why there was this explicit check, if it has a specific reason this PR should probably not be merged as it. I am using my fork right now, and it works for me 👍🏼