Skip to content

Conversation

@M123-dev
Copy link

@M123-dev M123-dev commented Feb 7, 2026

Fixes: #224

Somehow I (and some others) got a "Verkaufsorder"/Sale with the attribute

"amount": {
      "currency": "EUR",
      "value": 0.0,
      "fractionDigits": 2
    },

Which caused an error because the parser explicitly checked for value != 0.0.

This pull request removes the explicit check for zero values when parsing the amount.value field, so a value of 0.0 will now be considered valid instead of being replaced with None.


That being said I am not sure why there was this explicit check, if it has a specific reason this PR should probably not be merged as it. I am using my fork right now, and it works for me 👍🏼

Modified value assignment to allow None when amount is zero.
@RealCLanger
Copy link
Collaborator

Thanks for the contribution. I enabled the checks and it shows that there is a formatting error. Can you please take a look and update your change.

The parsing tests seem to work fine, though, so I think your change should be integrated when everything is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AssertionError while running dl_docs

2 participants