Update libdatatrie to 6ef4485474890606946ed208ff453231b581cdf1 #75
Open
c4f3a0ce wants to merge 3 commits intopytries:masterfrom
Open
Update libdatatrie to 6ef4485474890606946ed208ff453231b581cdf1 #75c4f3a0ce wants to merge 3 commits intopytries:masterfrom
c4f3a0ce wants to merge 3 commits intopytries:masterfrom
Conversation
provide tests for pytries#74 This resolves pytries#74
Author
|
So it seems that it doesn't resolve the problem completely. It is less prominent, but some segfaults still occur (https://travis-ci.org/pytries/datrie/jobs/622241476). |
3070096 to
3b09cbb
Compare
Author
|
Also this falsifying example: trie = datrie.Trie([chr(i) for i in range(1500)])
trie['ÿ0'] = True
trie['foo'] = True
'foo' in trie
# True
'ÿ0' in trie
# Falseis troubling. Seems related to trie_without_nil = datrie.Trie([chr(i) for i in range(1, 1500)])
trie_without_nil['ÿ0'] = True
'ÿ0' in trie_without_nil
# TrueWhich kind of makes sense. Maybe @thep can shed some light on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Resolves #74